Fix hang in toBuffer when spawned process writes a lot of data to stderr.#587
Open
davidmfoley wants to merge 1 commit intoaheckmann:masterfrom
Open
Fix hang in toBuffer when spawned process writes a lot of data to stderr.#587davidmfoley wants to merge 1 commit intoaheckmann:masterfrom
davidmfoley wants to merge 1 commit intoaheckmann:masterfrom
Conversation
In cases where stderr streams a lot of diagnostic, the process would block waiting for stderr buffer flush. We saw this occur with a PDF (ghostscript logging warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where stderr streams a lot of diagnostic, the process
would block waiting for stderr buffer flush,
consequently toBuffer would never call back.
We saw this occur with a PDF (ghostscript warnings sent to stderr).